This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7fca6ede19af: Fix removing first item in languages list
(authored by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17218?vs=46412&id=48512#toc
REPOSITORY
R119 Plasma Desktop
CHANGES
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in translationsmodel.cpp:216
> Changing from index < 1 to checking count makes sense, but I would still check
>
> if (index < 0) {return;}
>
> in addition to the count to catch out-of-sync erorrs. I think then you
> wouldn't ne
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> translationsmodel.cpp:216
>
> -if (index < 1) {
> +if (m_selectedLanguages.count() < 2) {
> return;
Changing from index < 1 to checki
hein added reviewers: davidedmundson, broulik.
hein added a comment.
Ping?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D17218
To: hein, #plasma, davidedmundson, broulik
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterber
hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Instead, we want to disallow removing when the count drops to 1.
BUG:401473
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
