D17393: [Folder View] make file context menu consistent with Dolphin's

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d75a37b58992: [Folder View] make file context menu consistent with Dolphin's (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17393?vs=4

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham added a comment. Thanks Eike! :) REPOSITORY R119 Plasma Desktop BRANCH context-menu-consistency-with-dolphin (branched from master) REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein, #vdg, ndavis Cc: ndavis, mart, janpr, plasma-devel, GB_2, ragreen,

D17393: [Folder View] make file context menu consistent with Dolphin's

hein accepted this revision. hein added a comment. Alrighty, I'll go in with the majority opinion then. Consistency is certainly an improvement by itself. Go go go! REPOSITORY R119 Plasma Desktop BRANCH context-menu-consistency-with-dolphin (branched from master) REVISION DETAIL https

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham added a comment. Since this is VDG-accepted and most of the comments seem to be slightly to strongly positive so far, if I don't get a formal Changes Requested status from someone in #plasma , I'll land on December 19th (or earlier if I get a

D17393: [Folder View] make file context menu consistent with Dolphin's

ndavis added a comment. +1 to making the menus the same. In D17393#373155 , @hein wrote: > Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.)

D17393: [Folder View] make file context menu consistent with Dolphin's

mart added a comment. important is that "open with $default" and "open with..." are grouped together. apart from that i don't have much preferences for one or the other REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein Cc: mar

D17393: [Folder View] make file context menu consistent with Dolphin's

janpr added a comment. I agree that Dolphin's menu makes more sense. If this turns out to be controversial, maybe the order should be easier to change, instead of having it hard coded... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #pla

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham added a comment. Hmm, I prefer the Dolphin one for the following reasons: 1. Having the the "open with" item near the top makes sense because it's likely the most commonly used item 2. Having the "open" items grouped together makes sense, since they're both similar actions, and

D17393: [Folder View] make file context menu consistent with Dolphin's

hein added a comment. Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.) I prefer FV's. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #pla

D17393: [Folder View] make file context menu consistent with Dolphin's

anthonyfieroni added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham updated this revision to Diff 47003. ngraham added a comment. Also give the Properties action a shortcut, so now the menu is 100% identical with Dolphin's REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17393?vs=47000&id=47003 BRANCH conte

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 401652 FIXED-IN: 5.15.0 TEST PLAN Folder view now: Matches Dolphin: (the lack