D17394: [Device Notifier] Fix transition animation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17394?vs=47001&id=47023 RE

D17394: [Device Notifier] Fix transition animation

thsurrel added a comment. In D17394#372523 , @broulik wrote: > Is this Bug 379759? I don't think so, but I will have a look at that one too. If any of you guys can have a look at my other device notifier patches, that would be really

D17394: [Device Notifier] Fix transition animation

thsurrel added inline comments. INLINE COMMENTS > davidedmundson wrote in DeviceItem.qml:197 > alwaysRunToEnd : true That does not work by itself. REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D17394 To: thsur

D17394: [Device Notifier] Fix transition animation

broulik added a comment. Is this Bug 379759? REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D17394 To: thsurrel, #plasma, #vdg, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenB

D17394: [Device Notifier] Fix transition animation

davidedmundson added inline comments. INLINE COMMENTS > DeviceItem.qml:197 > NumberAnimation { > property: "opacity" > from: 0 alwaysRunToEnd : true REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) RE

D17394: [Device Notifier] Fix transition animation

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch! This works and looks good to me, but let's make sure the #plasma folks agree. :) REPOSITORY R120 Plasma Workspace BRANCH arc_tra

D17394: [Device Notifier] Fix transition animation

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the specific case of having the device notifier opened and inserting a device that has