D17598: Improve "No internet connection!" error message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:131071136f56: Improve "No internet connection!" error message (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=63734&i

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 63734. ngraham added a comment. Fix diff REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=63723&id=63734 BRANCH arcpatch-D17598 REVISION DETAIL https://phabricator.kde.org/D17598 AFFECTED F

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 63723. ngraham added a comment. Rebase and update message REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48441&id=63723 BRANCH arcpatch-D17598 REVISION DETAIL https://phabricator.kde.org/D

D17598: Improve "No internet connection!" error message

GB_2 added inline comments. INLINE COMMENTS > BrowsingPage.qml:73 > +horizontalAlignment: Text.AlignHCenter > +text: xi18nc("@info", "Unable to load > applicationsplease verify Internet connectivity") > +} I'd put a dot after "applications" and "conne

D17598: Improve "No internet connection!" error message

ngraham added a comment. Not really. The text is not long, while the window size is user-adjustible so the empty space area can potentially be very large. REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL https:/

D17598: Improve "No internet connection!" error message

shubham added a comment. @rooty yeah, it depends on the available space. The main motive should be full up the empty space. @ngraham Is there any possible representation where we can just eliminate or use up that empty space. REPOSITORY R134 Discover Software Store BRANCH better-no-co

D17598: Improve "No internet connection!" error message

rooty added a comment. it might work on the left, but i think this is better because it takes up the entire pane, and is important enough to warrant doing so for example, F6517329: image.png F6517334: image.png

D17598: Improve "No internet connection!" error message

shubham added a comment. In D17598#384293 , @ngraham wrote: > In D17598#384289 , @shubham wrote: > > > Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or to

D17598: Improve "No internet connection!" error message

ngraham added a comment. In D17598#384289 , @shubham wrote: > Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or to the free space on the left? There is no real rule here. It's more of "what looks

D17598: Improve "No internet connection!" error message

shubham added a comment. Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or to the free space on the left? REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL https://phabr

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48441. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48440&id=48441 BRANCH better-no-connectivity-error-message (branched from master) REVISION DET

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48440. ngraham added a comment. Tighten up the wording a tiny bit REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48439&id=48440 BRANCH better-no-connectivity-error-message (branched from mast

D17598: Improve "No internet connection!" error message

rooty added a comment. loving the icon, it really stresses the importance of checking whether your internet connection's working without being (too) imposing REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL http

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48439. ngraham added a comment. Add an icon per #VDG suggestion REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48408&id=48439 BRANCH better-no-connectiv

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48408. ngraham added a comment. "Could not" -> "Unable to" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48372&id=48408 BRANCH better-no-connectivity-error-message (branched from master) RE

D17598: Improve "No internet connection!" error message

shubham accepted this revision. shubham added a comment. This revision is now accepted and ready to land. Looks good this way round. +1 REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 48372. ngraham added a comment. Add a line break REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=47625&id=48372 BRANCH better-no-connectivity-error-message (branched from master) REVISION DET

D17598: Improve "No internet connection!" error message

shubham added a comment. It will look much better. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensre

D17598: Improve "No internet connection!" error message

ngraham added a comment. How come? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D17598: Improve "No internet connection!" error message

shubham added a comment. Shouldn't the second part of the sentence be in its own line? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenB

D17598: Improve "No internet connection!" error message

ngraham added a comment. Ping! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 47625. ngraham added a comment. Improve message REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=47610&id=47625 BRANCH better-no-connectivity-error-message (branched from master) REVISION DETA

D17598: Improve "No internet connection!" error message

apol added a comment. I wonder if "app" is the right term. How about "could not load the featured applications"? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: pino, plasma-devel, GB_2, rag

D17598: Improve "No internet connection!" error message

pino added a comment. The error message is still not optimal (contractions, not correct spelling of "the Internet", etc). "Could not load any application; please verify your network connectivity." REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D1759

D17598: Improve "No internet connection!" error message

ngraham created this revision. ngraham added reviewers: Discover Software Store, VDG, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Old message was a bit unclear. Hopefully this is better. TEST PLAN T