D18006: Include only the largest size for the "Next" wallpaper

ngraham abandoned this revision. ngraham added a comment. All right, no problem! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D18006 To: ngraham, #vdg, #breeze, mart Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D18006: Include only the largest size for the "Next" wallpaper

filipf added a comment. In D18006#595782 , @ngraham wrote: > The whole point was to save some space on the user's machine. However trading space savings for load time maybe isn't the best trade-off? 18 MB isn't really all that much of a

D18006: Include only the largest size for the "Next" wallpaper

ngraham added a comment. The whole point was to save some space on the user's machine. However trading space savings for load time maybe isn't the best trade-off? 18 MB isn't really all that much of a savings. Should we shelve this idea? REPOSITORY R31 Breeze REVISION DETAIL

D18006: Include only the largest size for the "Next" wallpaper

apol added a comment. In D18006#595773 , @apol wrote: > -1 I just saw what this revision depends on. So it could make sense. I'll leave it at -0 because caches are bad. REPOSITORY R31 Breeze REVISION DETAIL

D18006: Include only the largest size for the "Next" wallpaper

apol added a comment. -1 This will also reduce load time considerably (I did the profiling before, using the same resolution is a big win). Also you'll get to save quite some IO. If this is a problem, I'd suggest looking into doing these wallpapers in svg or even QML. REPOSITORY

D18006: Include only the largest size for the "Next" wallpaper

ngraham planned changes to this revision. ngraham added a comment. Per discussion in D18005 , we're not gonna do this for 5.15. Instead we'll try to get a local wallpaper cache, and then we can do it. REPOSITORY R31 Breeze REVISION DETAIL

D18006: Include only the largest size for the "Next" wallpaper

davidedmundson added a comment. I said it's roughly unchanged, we resize to the uncropped version of the image. --- As per IRC discussion yesterday. We can do it in the extra wallpapers, and see how that goes, lets not change "Next" this release. REPOSITORY R31 Breeze REVISION

D18006: Include only the largest size for the "Next" wallpaper

ngraham added a subscriber: davidedmundson. ngraham added a comment. According to @davidedmundson, runtime memory is unchanged because we internally store a version that's resized and cropped according to the actual screen dimensions and pixel density. REPOSITORY R31 Breeze REVISION

D18006: Include only the largest size for the "Next" wallpaper

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. has runtime memory been taken into account? (better with massif than with the unreliable top/ksysguard) runtime memory usage should be taken into account as well, loading a big

D18006: Include only the largest size for the "Next" wallpaper

ngraham added a comment. Thanks for noticing that! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D18006 To: ngraham, #vdg, #breeze Cc: filipf, kvermette, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18006: Include only the largest size for the "Next" wallpaper

filipf added a comment. And from my understanding this removes the file the SDDM theme needs so I created D18007 as a dependent revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D18006 To: ngraham, #vdg, #breeze Cc: filipf,

D18006: Include only the largest size for the "Next" wallpaper

filipf added subscribers: kvermette, filipf. filipf added a comment. I've reproduced what the issue was before. Tests done with a 1280x1024 monitor. - **Tested on a Kubuntu 16.04 install with Plasma** Using the optimized 1280x1024 wallpaper: F6529646:

D18006: Include only the largest size for the "Next" wallpaper

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Companion to D18005 ; everything there applies here.