D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to `plasma-workspace` or `digital-clock` specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. To pad out the 5.15 feature list, maybe?  REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #plasma, #vdg Cc: broulik, karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, rooty, plasma-devel,

D18019: [Digital Clock] Add ability to set a custom date format string

broulik added a comment. Why was this committed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #plasma, #vdg Cc: broulik, karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, rooty, plasma-devel, jraleigh, GB_2, ragreen,

D18019: [Digital Clock] Add ability to set a custom date format string

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:235fa8107dab: [Digital Clock] Add ability to set a custom date format string (authored by Zren). REPOSITORY R120

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. > D18155 Looking at the alternative patch, I've renamed the config key variable to `customDateFormat`. Most of the differences stem from not using a "variant" data type for `DigitalClock.qml`'s `dateFormat` variable. The `string

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49332. Zren edited the summary of this revision. Zren edited the test plan for this revision. Zren added a comment. - Rename config key from `dateFormatStr` and config TextField `dateFormatTextField` to `customDateFormat`. - Remove the "Color Format

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. In D18019#390363 , @Zren wrote: > I played around with a prettier looking example table. > > F6538091: 2019-01-10___02-37-24.png > F6538098: 2019-01-10___02-42-25.png

D18019: [Digital Clock] Add ability to set a custom date format string

davidedmundson added a comment. I think these changes ultimately come down to two questions: **1) Is it something we actually want to customise at a per-plasmoid level, or is it a hack round something else? ** I quite like ndavis's reply. > user might prefer to use ISO date

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49137. Zren edited the summary of this revision. Zren added a comment. Translate the "Time Format Documentation" link. Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated). Place the 2 links below the text

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a `plasmoid.globalConfiguration.dateFormatStr` API which all widget instances (on all panels/screens) were bound to, so the user only had to

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. I think some users may want to have a separate date format for their clock than the rest of the system. A user might prefer to use ISO date format with only the last 2 digits of the year in their clock because it saves space, but they might prefer to use regular ISO

D18019: [Digital Clock] Add ability to set a custom date format string

abetts added a comment. Is there a way that the custom date setting can be in its own window pop up instead of building into the KCM and pushing down the control that's below this setting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren,

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. Darn. Thanks Christoph. If global changes are currently impossible due to lack of support in Qt, I think this is a reasonable approach for now, since it's the most prominent place where formatted times and dates are actually displayed in the UI. Therefore

D18019: [Digital Clock] Add ability to set a custom date format string

cfeck added a comment. Bug 340982 is about system-wide locale format changes. Qt currently does not have a way to customize its internal CLDR database. This change is indeed only about the Plasma clock, somewhat a workaround for the bug. REPOSITORY R120 Plasma Workspace REVISION

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. However, to @mart's point, the custom format chooser is systemwide on macOS, not limited to their digital clock equivalent. Systemwide does indeed seem like the more appropriate place, but I'm not sure if that would be compatible with Qt's locale system though?

D18019: [Digital Clock] Add ability to set a custom date format string

ngraham added a comment. "Very geeky options" aren't generally a problem as long as they're not the default setting. In fact, they're one of the big things that KDE is known for so in principle I think this is great as long as it doesn't get in the way of people who are not very geeky.

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388829 , @ndavis wrote: > Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget? The time format docs

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. In D18019#388876 , @mart wrote: > is this the right place for it? (a text field to enter the "magic" date format letters is a very geeky ui, and i would prefer to not go there) shouldn't be a generic localization/date

D18019: [Digital Clock] Add ability to set a custom date format string

mart added a comment. is this the right place for it? (a text field to enter the "magic" date format letters is a very geeky ui, and i would prefer to not go there) shouldn't be a generic localization/date format setting? (and with also a graphical ui to generate this) REPOSITORY R120

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. In D18019#388819 , @Zren wrote: > In D18019#388811 , @ndavis wrote: > > > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. >

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388811 , @ndavis wrote: > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. Adding a second link is pretty easy, though I wrote this before I noticed your

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. > Should I add presets like Event Calendar? I'm leaning towards no, but an example of the custom time formatting and another of HTML styling would be a good idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren,

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added inline comments. INLINE COMMENTS > configAppearance.qml:145 > +'name': "custom" > } > ] Does this also need a `i18nc("custom date format", "Custom")` translation context? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18019: [Digital Clock] Add ability to set a custom date format string

rooty added a comment. a thousand times yes... this is amazing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #plasma, #vdg Cc: rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18019: [Digital Clock] Add ability to set a custom date format string

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Adds a new `dateFormatStr` config key which is used when the `dateFormat` "StringEnum" is set to `custom`. Shows a link to the Qt time