D18189: Fix ComboBox

2019-02-18 Thread Aleix Pol Gonzalez
apol closed this revision. apol added a comment. This was fixed subsequently. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBo

D18189: Fix ComboBox

2019-01-17 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > apol wrote in ComboBox.qml:207 > delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a > popup. > > http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html > > Also we didn't use to specify a delegate to the ListV

D18189: Fix ComboBox

2019-01-17 Thread Kai Uwe Broulik
broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. This breaks mouse wheel interaction REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: broulik, david

D18189: Fix ComboBox

2019-01-16 Thread Aleix Pol Gonzalez
apol added a comment. https://phabricator.kde.org/D18299 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D18189: Fix ComboBox

2019-01-16 Thread Aleix Pol Gonzalez
apol added a comment. I gave it a test and indeed selecting also needs looking into. I guess I just didn't fully fix it. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, jral

D18189: Fix ComboBox

2019-01-16 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in ComboBox.qml:207 > Breaking it down it's this one line that causes major regressions for me > though I can't immediately see why. > > Can you elaborate on what was broken and why you changed it? delegateModel property doesn'

D18189: Fix ComboBox

2019-01-16 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > ComboBox.qml:207 > implicitHeight: contentHeight > -model: controlRoot.popup.visible ? controlRoot.delegateModel : > null > +model: controlRoot.model > +delegate: controlRoot.delegate Breaki

D18189: Fix ComboBox

2019-01-15 Thread David Edmundson
davidedmundson added a comment. I'm finding issues with combobox and this patch. Using the test supplied I can't select other items. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, pl

D18189: Fix ComboBox

2019-01-14 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R858:4f00b0cabc12: Fix ComboBox (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18189?vs=49258&id=49439 REVISION DETAIL h

D18189: Fix ComboBox

2019-01-11 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It wasn't working at all REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REV