D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2015bad98e64: Improve Desktop/Plasma Theme KCM (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18247?vs=49453=49461 REVISION DETAIL

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1. The only change here that I think might be remotely controversial is changing "Desktop theme" to Plasma theme". But I thin that's a very good change since it improves the ability to

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Björn Feber
GB_2 added a comment. In D18247#393021 , @davidedmundson wrote: > > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and > > Where? > > > renames

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread David Edmundson
davidedmundson added a comment. > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and Where? > renames the KCM to "Plasma Theme". I can only see this. REPOSITORY R119 Plasma Desktop

D18247: Improve Desktop/Plasma Theme KCM

2019-01-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Similar to D18206 . The Desktop/Plasma Theme KCM has some