davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
See the end of QComboBox::initStyleOption
if (d->container && d->container->isVisible())
option->state
broulik added a comment.
That doesn't fix the linked bug, however
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D18284
To: davidedmundson
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreu
davidedmundson added a comment.
When we click without explicit keyboard focus:
Currently we get black text on dark blue background.
After this patch we get black text on a light background.
Which I understood to be the main issue in that bug report.
REPOSITORY
R858 Qt Quick Cont
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
as far as I understood the issue is that in the popup the list elements are
elided because they're too narrow. So, we have two separate bugs I presume :)
REPOSITORY
R858 Qt Quick Contro
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:c4a35f5e36bd: Set CombooBox QStyleOptionState == On
rather than Sunken to match qwidgets (authored by davidedmundson).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
