D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd created this revision. arrowd added a reviewer: KDE Applications. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY Second part of fix for a BUG 398998 ( https://bugs.kde.org/show_bug.cgi?id=398998 ). Kat

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Ping? Any chance to get this into 5.15? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #kde_applications Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Bump(); REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Pingy-ping, bumpy-bump. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

cullmann added a reviewer: broulik. cullmann added a comment. Perhaps Kai has some opinion. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik Cc: cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Monthly bump. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik Cc: cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

apol added a comment. Overall this makes sense to me, this assumes though that there will never be a file ending with `:digit`, is that something we can live with? INLINE COMMENTS > urlinfo.h:68 > + */ > +line = match.captured(1).toUInt(); > +column = matc

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd updated this revision to Diff 54774. arrowd marked an inline comment as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=49633&id=54774 BRANCH cursor REVISION DETAIL https://phabr

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#437985 , @apol wrote: > Overall this makes sense to me, this assumes though that there will never be a file ending with `:digit`, is that something we can live with? Judging from UrlInfo(QStrin

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Can I finally push this? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

elvisangelaccio added a comment. Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? INLINE COMMENTS > urlinfo.h:45-52 > +if (QFile::exists(path)) { > +/** > + * create absol

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#444642 , @elvisangelaccio wrote: > Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? I just copied this from Kate p

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added inline comments. INLINE COMMENTS > elvisangelaccio wrote in urlinfo.h:45-52 > Why doesn't it parse the URL if the file already exists? If the file is named `foo:123`, it refuses to search for cursor infomation and just open it. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Is the makeURL function still used, or should it be removed now? INLINE COMMENTS > urlinfo.h:39 > + */ > +UrlInfo(QString path) > +: line(0), column(0) const QStr

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#445829 , @dfaure wrote: > Is the makeURL function still used, or should it be removed now? Yep, it is still used in a bunch of other places. INLINE COMMENTS > dfaure wrote in urlinfo.h:39 > const QString

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure added inline comments. INLINE COMMENTS > arrowd wrote in urlinfo.h:39 > > const QString & > > There is `path.chop(match.capturedLength());`, which requires non-const > `QString`. > > > And what if it's a URL? At this point this string is pathOrUrl. > > Well, `if (QFile::exists(path))`

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd updated this revision to Diff 55879. arrowd marked 5 inline comments as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=54774&id=55879 BRANCH cursor REVISION DETAIL https://phabr

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added inline comments. INLINE COMMENTS > dfaure wrote in urlinfo.h:77 > But then you can't do `kde-open5 www.google.fr` anymore, right? > > I see what you mean with typo handling, but there is no perfect solution. > Either we treat typos as URLs (but it means we also treat actual URLs as

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > urlinfo.h:76 > + * - make relative paths absolute using the current working > directory > + * - prefer local file, if in doubt! > + */ remo

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:8072a6acf221: Add support for passing cursor information via URL parameters when running… (authored by arrowd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18296?vs=55879&id=55973#toc REPOS