broulik added a comment.
I checked Qt source code and Qt indeed should handle this on its own, it also
works fine hwere without the code.
Worse, the explicit assignment from QML breaks any binding set on
`currentIndex`.
In the handler that's called when the delegate model creates a
apol added inline comments.
INLINE COMMENTS
> broulik wrote in ComboBox.qml:58
> Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a
> `ComboBox` is recommended as:
> "This ensures that the interaction works as expected, and the popup will
> automatically close when
broulik added inline comments.
INLINE COMMENTS
> ComboBox.qml:58
> +controlRoot.currentIndex = index;
> +controlRoot.popup.visible = false;
> +}
Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a
`ComboBox` is recommended as:
"This
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:cb49b355f946: ComboBox: fix default delegate (authored by
apol).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18299?vs=49646=49648
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Should use the selected item when it's interacted with using the mouse.
TEST PLAN
Selecting an item
