D18394: Add OTP support for openconnect VPN

This revision was automatically updated to reflect the committed changes. Closed by commit R116:8fb5c6192c15: Add OTP support for openconnect VPN (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18394?vs=57394&id=57634#toc REPOSITORY R116 Plasma Network Management

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 57394. enriquem added a comment. I addressed your comments. Sorry for the careless coding in what spaces are concerned. BTW, I added a missing QStringLiteral. I believe the combobox size constraints are fixed now (although I liked it better before).

D18394: Add OTP support for openconnect VPN

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Just fix those minor issues, otherwise it looks good to me, I'll verify on Monday, but I believe it's safe to push this. INLINE COMMENTS > openconnectauth.cpp:287 > +ret =

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 57294. enriquem added a comment. I believe I addressed all of your comments. Please check your email for testing options. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=55714&id=57294 REVISION DETAIL https://phabricator.kde.org/D183

D18394: Add OTP support for openconnect VPN

jgrulich added a comment. Sorry for the delay, I promise that I will start reviewing this more frequently so it gets merged just in time for Plasma 5.16 (we have 2 weeks). One more thing: When I open the "Token authentication" dialog, the "Token secret" label is not aligned with the tex

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 55714. enriquem added a comment. Update per comments above CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=55653&id=55714 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openco

D18394: Add OTP support for openconnect VPN

enriquem added a comment. > ! In D18394#445411 , @jgrulich wrote: > All forms in the kcm use "Label: input" so I would like all the options to follow same pattern. OK. >> b) I agree on the PasswordField, although this being an OT

D18394: Add OTP support for openconnect VPN

jgrulich added a comment. In D18394#445224 , @enriquem wrote: > In D18394#444795 , @jgrulich wrote: > > > 1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token

D18394: Add OTP support for openconnect VPN

enriquem added inline comments. INLINE COMMENTS > jgrulich wrote in nm-openconnect-service.h:41 > Leftover from the other review? Not really. It's a feature in NetworkManager. If the functionality is not needed, it can be dropped. REPOSITORY R116 Plasma Network Management Applet REVISION DE

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 55653. enriquem added a comment. Hopefully there are no more trailing spaces. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=50749&id=55653 REVISION DETAIL https://phabricator.kde.o

D18394: Add OTP support for openconnect VPN

enriquem added a comment. In D18394#444795 , @jgrulich wrote: > 1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It

D18394: Add OTP support for openconnect VPN

jgrulich added a comment. 1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It can be our PasswordField widget from libs/editor/widgets/. Or it's not secret in the

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 50749. enriquem added a comment. Changed tooltips CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=50698&id=50749 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 50698. enriquem added a comment. Changed tooltips No need for a new enum CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=50665&id=50698 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 50665. enriquem added a comment. Herald added 1 blocking reviewer(s): jgrulich. Removed updateLog calls Properly initialize d->tokens Change the config dialog so that (a) 'Apply' does not become active when the user clicks on the 'Show Tokens' button,

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 50279. enriquem added a comment. Corrects minor bug in one call to updateLog. However, all calls to updateLog have to be reviewed if this goes to production CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49949&id=50279 REVISION DETAIL

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49949. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49946&id=49949 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-openconnect-service.h vpn/openconnect/opencon

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49946. enriquem added a comment. Changed the buildup of the "tokens" ComoBox REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49921&id=49946 REVISION DETAIL https://phabricator.kde.or

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49921. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49920&id=49921 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-openconnect-service.h vpn/openconnect/opencon

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49920. enriquem added a comment. Amended to remove global tokenModeList REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49911&id=49920 REVISION DETAIL https://phabricator.kde.org/D18

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49911. enriquem added a comment. I addressed your comments, except the ones regarding macro definitions, since I am unsure thar applicable versions of openconnect have compatible parameters. I will find out and revisit the comment later CHANGES SINCE LA

D18394: Add OTP support for openconnect VPN

pino added a comment. Hi Enrique, I'm not a plasma-nm developer, however I provide some tips & hints regarding your patch. Other than what I noted already, there are few more things that apply in general: - make sure to respect the indentation: each level by 4 spaces with no ta

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49906. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49899&id=49906 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnec

D18394: Add OTP support for openconnect VPN

enriquem created this revision. enriquem added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. enriquem requested review of this revision. REVISION SUMMARY With this patch, One Time Password (OTP) support is added to the openconnect VPN settings an