D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. @vpilo to move this forward, maybe just remove the header/title in the menu entirely. It's not really necessary after all. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg, jgrulich Cc: mart,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a subscriber: mart. ngraham added a comment. In D18504#405873 , @vpilo wrote: > In D18504#405816 , @ngraham wrote: > > > The problem is that you're using a disabled menu item for the

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#405816 , @ngraham wrote: > In D18504#405444 , @vpilo wrote: > > > In D18504#404332 , @Codezela wrote: > > > > > small

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. In D18504#405444 , @vpilo wrote: > In D18504#404332 , @Codezela wrote: > > > small tweak we can make the connection name in the context menu bold header msybe > >

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#404332 , @Codezela wrote: > small tweak we can make the connection name in the context menu bold header msybe > because it look like disabled now > it looks strange to me > what do u think I

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. I can no longer right click the details entries (e.g. IP address) to copy them to clipboard, the menu is blocked by this new menu. Perhaps the menu should only be on the text sections of

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

Codezela added a comment. i think we need to make the connection name in 5he context menu bold headr not the lite color it looks strange to me REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg, jgrulich Cc: Codezela,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:32d76665a694: [plasma-nm/applet] Add right-click context menu to directly customize a… (authored by vpilo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me, I woud personally keep the header in the popup menu, at least I know I clicked on correct connection. REPOSITORY R116 Plasma Network Management Applet BRANCH

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#399818 , @ngraham wrote: > In D18504#399653 , @jgrulich wrote: > > > Does it work for you on wayland? When the menu opens, it opens in the left top corner of the

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. In D18504#399653 , @jgrulich wrote: > Does it work for you on wayland? When the menu opens, it opens in the left top corner of the applet and cannot be closed unless you select any option, but that's probably wayland +

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo updated this revision to Diff 50248. vpilo marked 4 inline comments as done. vpilo added a comment. - Review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18504?vs=50204=50248 BRANCH vpilo/contextMenu REVISION

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#399653 , @jgrulich wrote: > Does it work for you on wayland? When the menu opens, it opens in the left top corner of the applet and cannot be closed unless you select any option, but that's probably wayland + qt

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

broulik added a comment. > Does it work for you on wayland? Haven't tried, I suspect it fails to set a proper transient parent for the menu REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: broulik, jgrulich,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

jgrulich added a comment. In D18504#399473 , @broulik wrote: > > I'm not convinced this is needed at all. How often do you need to modify a connection? > > Often enough that it annoys me that I have to open the connection editor first and

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

broulik added a comment. > I'm not convinced this is needed at all. How often do you need to modify a connection? Often enough that it annoys me that I have to open the connection editor first and then search the connection *again* in the list of connections. +1 for the change. INLINE

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

jgrulich added a comment. I'm not convinced this is needed at all. How often do you need to modify a connection? I also don't think many people would discover this feature, because many of them also didn't discover context menu in KCM. REPOSITORY R116 Plasma Network Management Applet

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. I think a context menu is fine here, since it's not replacing anything else. We can examine the non-right-click presentation later. It might be nice to have a Configure button/icon show up on hover just like the disconnect one does. That's what Kirigami lists do.

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#399356 , @abetts wrote: > Do you prefer a right click over a settings or 3-dot button? There's already very little space - I personally think it would become cluttered. An alternative might be a link

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

abetts added a comment. Do you prefer a right click over a settings or 3-dot button? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#399351 , @GB_2 wrote: > Next time please upload images directly to Phabricator.  REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

GB_2 added a comment. Thanks! Looks good! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

GB_2 added a comment. Next time please upload images directly to Phabricator. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY Screenshot: https://imgur.com/MvnFdbW REPOSITORY R116 Plasma Network Management Applet BRANCH vpilo/contextMenu REVISION DETAIL