D18646: [Colors KCM] Add search and filter

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a1fbeb96dc6c: [Colors KCM] Add search and filter (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18646?vs=53304=53422#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE

D18646: [Colors KCM] Add search and filter

broulik updated this revision to Diff 53304. broulik added a comment. This revision is now accepted and ready to land. - Refactor to use proper `QAbstractListModel` for colors - Fix current scheme index following as you filter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18646: [Colors KCM] Add search and filter

broulik planned changes to this revision. broulik added a comment. The `selectedSchemeIndex` stuff doesn't take into account the filtering, so the highlight is wrong when filtering and also when marking a theme for deletion the index changes to the next one but might end up applying a

D18646: [Colors KCM] Add search and filter

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. LGTM aside from the minor naming nitpick. INLINE COMMENTS > filterproxymodel.cpp:31 > + > +void FilterProxyModel::setSourceModelProxy(QAbstractItemModel *sourceModel) > +{ Why did you call

D18646: [Colors KCM] Add search and filter

broulik added a comment. > It does kind of beg the question of why this is the only grid view that has a search, of course. Dunno, colors has significantly more entries than the other KCMs. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To:

D18646: [Colors KCM] Add search and filter

ngraham added a comment. UI-wise, I think this can go in. It does kind of beg the question of why this is the only grid view that has a search, of course. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To: broulik, #plasma, #vdg Cc:

D18646: [Colors KCM] Add search and filter

broulik added a comment. Is this good now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To: broulik, #plasma, #vdg Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18646: [Colors KCM] Add search and filter

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:129 > why do we need a different approach from the way you've done the clear button? If I could change the left padding of the `ComboBox` button I would have done that and placed an icon ontop. However, since

D18646: [Colors KCM] Add search and filter

davidedmundson added inline comments. INLINE COMMENTS > main.qml:129 > + > +// HACK QQC2 doesn't support icons, so we just tamper with > the desktop style ComboBox's background > +// and inject a nice little filter icon. why do we need a different approach from

D18646: [Colors KCM] Add search and filter

ngraham accepted this revision as: VDG. ngraham added a comment. UI and interactivity are great. Very nice addition. Would be nice to have the search field as a re-usable component, yes. As in D18716: Add a SearchField component . REPOSITORY R119

D18646: [Colors KCM] Add search and filter

broulik updated this revision to Diff 50838. broulik edited the test plan for this revision. broulik added a comment. - Add filter icon to ComboBox, needs D18718 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18646: [Colors KCM] Add search and filter

broulik updated this revision to Diff 50667. broulik edited the test plan for this revision. broulik added a comment. - Change filter into a simple `ComboBox`, simplifies code a lot - Change placeholder to "Search..." to be consistent with other KCMs - Fixed left-to-right layout issues

D18646: [Colors KCM] Add search and filter

broulik planned changes to this revision. broulik added a comment. Alright, will change it to a `ComboBox`. We might lose the filter icon, which I quite liked, in the process, though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To: broulik,

D18646: [Colors KCM] Add search and filter

ngraham added a comment. In D18646#403270 , @broulik wrote: > An alternative would be > F6581375: Screenshot_20190201_162719.png I would prefer this, but with the filter being a real combobox. In

D18646: [Colors KCM] Add search and filter

broulik added a comment. An alternative would be F6581375: Screenshot_20190201_162719.png which is a lot more obvious than a tiny filter icon. Your decision, also whether it should highlight when filtered or not (it does not in Widget Explorer

D18646: [Colors KCM] Add search and filter

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a search bar to search for schemes in the list as well as a filter to show only