D18696: Update `libdbusmenuqt` and the AppMenu plugin

2019-02-05 Thread Alexander Schlarb
ntninja added a comment. @Zren: Updated! Thanks for pointing this out! @cfeck: It contains the fix from bug 399975 yes, but I don't know whether it will fix LyX. REVISION DETAIL https://phabricator.kde.org/D18696 To: ntninja, Zren, majohnson Cc: cfeck, plasma-devel, jraleigh, GB_2,

D18696: Update `libdbusmenuqt` and the AppMenu plugin

2019-02-05 Thread Alexander Schlarb
ntninja updated this revision to Diff 50993. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18696?vs=50770=50993 REVISION DETAIL https://phabricator.kde.org/D18696 AFFECTED FILES plugin/appmenumodel.cpp plugin/appmenumodel.h plugin/appmenuplugin.cpp

D18696: Update `libdbusmenuqt` and the AppMenu plugin

2019-02-05 Thread Christoph Feck
cfeck added a comment. If this fixes bug 401725, please add a line "BUG: 401725" to the commit message. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D18696 To: ntninja, Zren, majohnson Cc: cfeck, plasma-devel, jraleigh, GB_2,

D18696: Update `libdbusmenuqt` and the AppMenu plugin

2019-02-04 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > CMakeLists.txt:27 > > -# add_subdirectory(test) > +add_subdirectory(test) We do not bundle the libdbusmenuqt test directory in this repo. So you need to comment this line out otherwise it will not build with the test directory missing.

D18696: Update `libdbusmenuqt` and the AppMenu plugin

2019-02-03 Thread Alexander Schlarb
ntninja created this revision. ntninja added reviewers: Zren, majohnson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ntninja requested review of this revision. REVISION SUMMARY What the title says, synchronize the relevant bits of source code with upstream