D18807: find volume feedback's runtime requirements

2019-02-07 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R115:9cab61adecb1: find volume feedback's runtime requirements (authored by sitter). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18807?vs=51084&id=

D18807: find volume feedback's runtime requirements

2019-02-07 Thread Jonathan Riddell
jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. works good REPOSITORY R115 Plasma Audio Volume Applet BRANCH runtime-deps REVISION DETAIL https://phabricator.kde.org/D18807 To: sitter, jriddell Cc: jriddell, plasma-devel, jra

D18807: find volume feedback's runtime requirements

2019-02-07 Thread Jonathan Riddell
jriddell added a comment. I've not checked the logic but adding more cmake runtime dep notices is good and can go into Plasma/5.15 branch, I can also update the candidate tar REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D18807 To: sitter Cc: jri

D18807: find volume feedback's runtime requirements

2019-02-07 Thread Harald Sitter
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY I'm in a good mood so there's even finders! - FindCanberra now also sets the version (this is necessary to hint directories for