D18814: Clarify the label of the Shell KRunner.

2019-02-07 Thread Valerio Pilo
vpilo abandoned this revision. vpilo added a comment. In D18814#407090 , @davidedmundson wrote: > What problem are we solving? > > If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case. I

D18814: Clarify the label of the Shell KRunner.

2019-02-07 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. By making this label long, the available room for the command itself is correspondingly reduced, and this UI already has a limited amount of horizontal space. It's probably wors

D18814: Clarify the label of the Shell KRunner.

2019-02-07 Thread David Edmundson
davidedmundson added a comment. What problem are we solving? If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18814 To: vpilo, #vdg, #plasma, ngraham Cc

D18814: Clarify the label of the Shell KRunner.

2019-02-07 Thread Valerio Pilo
vpilo added a comment. In D18814#407083 , @davidedmundson wrote: > It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run " "Run %1 in a shell" then? REPOSITORY R120 Plasma Wor

D18814: Clarify the label of the Shell KRunner.

2019-02-07 Thread David Edmundson
davidedmundson added a comment. It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run " REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18814 To: vpilo, #vdg, #plasma Cc: davidedmundson, plasma-deve

D18814: Clarify the label of the Shell KRunner.

2019-02-07 Thread Valerio Pilo
vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY This makes sure the end result of the consequence of clicking this runner's results (running a shell command). REPOSITORY R120 Plasm