D18903: Make Appearance KCMs' labels consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:089612d232fd: Make Appearance KCMs labels consistent (authored by filipf, committed by rooty). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18903: Make Appearance KCMs' labels consistent

davidedmundson added a comment. +1 from my side. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: davidedmundson, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18903: Make Appearance KCMs' labels consistent

filipf added a comment. In D18903#411590 , @ngraham wrote: > BTW could you explain the changes in more detail in the Summary section? Sure, just did that now. Sounds pretty technical but I think it summarizes everything done here.

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. BTW could you explain the changes in more detail in the Summary section? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18903: Make Appearance KCMs' labels consistent

ngraham accepted this revision. ngraham added a comment. Looking good to me now! I notice that the font installation and Emoticons KCMs display the comment rather than the KAboutData string in their headers, but this is a bug unrelated to your patch. Still, we should figure out what's

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51616. filipf added a comment. get rid of articles, better wording REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51602=51616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903

D18903: Make Appearance KCMs' labels consistent

GB_2 added a comment. Oops REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

GB_2 accepted this revision. GB_2 added a comment. In D18903#411538 , @ngraham wrote: > In D18903#411529 , @filipf wrote: > > > For this patch (and moving forward) we still have 2 dilemmas left then:

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. In D18903#411529 , @filipf wrote: > For this patch (and moving forward) we still have 2 dilemmas left then: > > - remove the article -> "Configure system fonts" instead of "Configure the system fonts"? My

D18903: Make Appearance KCMs' labels consistent

filipf added a comment. In D18903#411528 , @ngraham wrote: > Perfect. This strikes me as the exactly correct way to do it: The `KAboutData` string shows a real title, and the `Comment` provides the tooltip text. Can we do this for the few

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. Perfect. This strikes me as the exactly correct way to do it: The `KAboutData` string shows a real title, and the `Comment` provides the tooltip text. Can we do this for the few remaining KCMs in the appearance section too? Looks like there's a bug in the font

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51602. filipf added a comment. KAboutData i18n is the same as Name REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51601=51602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51601. filipf added a comment. . REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51600=51601 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903 AFFECTED FILES

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51600. filipf added a comment. . REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51598=51600 BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51598. filipf added a comment. try to fix it? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51597=51598 BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

filipf added a comment. Bah sorry, it pulled in some other non-related changes as well. Will fix if I figure out how or open up a new diff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik,

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51597. filipf added a comment. use verb style headers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51329=51597 BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. Putting the KCM name in the header would make semantic sense, though then we would have triple name duplication: in the header, in the sidebar, and in the titlebar. Maybe that's not so bad as long as they all display the same text though. REPOSITORY R119 Plasma

D18903: Make Appearance KCMs' labels consistent

GB_2 added a comment. We currently use the KAboutData name in headers, we can easily change them to real titles and leave the desktop files how they are currently (explanation sentences). Should we just use the KCM name in the header or something more explaining like "Look and Feel Theme

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. Exactly. Let's not go in circles here. The `comment` field in the desktop file and the KAboutData description are really meant to be tooltips or captions, not titles. Let's not try to awkwardly force them to be titles as a workaround for the fact that our KCMs

D18903: Make Appearance KCMs' labels consistent

broulik added a comment. So you had all these comments changed to be "more natural" and now you change them back to how they were before? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik,

D18903: Make Appearance KCMs' labels consistent

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Why are we doing this? The current one reads like a natural sentence, as a tooltip should; this is more like a title, but it's *not* a title. If we are trying to work around

D18903: Make Appearance KCMs' labels consistent

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Perfect! REPOSITORY R119 Plasma Desktop BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham,

D18903: Make Appearance KCMs' labels consistent

filipf updated this revision to Diff 51329. filipf added a comment. address metadata.desktop files; add another change for app style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51328=51329 BRANCH 516-appearance-header-labels (branched

D18903: Make Appearance KCMs' labels consistent

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As per VDG agreement, change the textual style of Appearance KCMs' labels and make them consistent. REPOSITORY R119 Plasma