D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#432878 , @mart wrote: > In D19044#432875 , @filipf wrote: > > > In D19044#432853 , @mart wrote: > > > > > uuh, no,

D19044: [InlineMessage] Do not draw shadows around the message

This revision was automatically updated to reflect the committed changes. Closed by commit R169:56ca5702d8a6: [InlineMessage] Do not draw shadows around the message (authored by filipf). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19044?vs=52923=54113

D19044: [InlineMessage] Do not draw shadows around the message

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. In D19044#432875 , @filipf wrote: > In D19044#432853 , @mart wrote: > > > uuh, no, this duplicates

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#432853 , @mart wrote: > uuh, no, this duplicates more, i meant moving things from the control to the template But I moved most of things from `src/controls/InlineMessage.qml` to

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. uuh, no, this duplicates more, i meant moving things from the control to the template REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel,

D19044: [InlineMessage] Do not draw shadows around the message

ngraham added a comment. In D19044#423965 , @Codezela wrote: > how can I try this in home https://community.kde.org/Infrastructure/Phabricator#How_to_review_someone_else.27s_patch If you need further assistance, please ask in the

D19044: [InlineMessage] Do not draw shadows around the message

Codezela added a comment. can we make this massages full width borderless total flat how can I try this in home sorry I am new in this things REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc: Codezela, rooty,

D19044: [InlineMessage] Do not draw shadows around the message

filipf updated this revision to Diff 52923. filipf added a comment. don't track the .directory file REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19044?vs=52922=52923 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19044 AFFECTED FILES

D19044: [InlineMessage] Do not draw shadows around the message

filipf updated this revision to Diff 52922. filipf added a comment. move most of InlineMessage into templates, use shadow in /controls, don't use a shadow in /styles/Material REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19044?vs=51774=52922 BRANCH

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#416559 , @mart wrote: > - whole InlineMessage should be moved into templates I've been trying to do this but there's several properties such as padding and contentItem (with a big ColumnLayout attached)

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. In D19044#419934 , @filipf wrote: > In D19044#416559 , @mart wrote: > > > - whole InlineMessage should be moved into templates > > > Im not home right now but I ran into

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#416559 , @mart wrote: > - whole InlineMessage should be moved into templates Im not home right now but I ran into an issuse with this step because that file I should move to templates already imports

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. do you still need further explanations on the steps to do? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc: rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, apol,

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. - whole InlineMessage should be moved into templates - background: item should be deleted such that it doesn't have any background at all (lines from 123 to 173) - in controls, an InlineMessage.qml is still present, and will be import "templates" as T

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. Don't fully understand the next course of action yet so if anyone wants to commandeer the revision for a speedier resolution, go ahead! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc:

D19044: [InlineMessage] Do not draw shadows around the message

rooty added a comment. In D19044#412934 , @abetts wrote: > In fact, long ago, when we first launched the current version, I also suggested making them flatter and all the way across the window. That way it didn't seem like it was floating. >

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. In D19044#414530 , @ngraham wrote: > In D19044#414479 , @mart wrote: > > > -1 > > this has to be done at most for the desktop style and the desktop style only > > >

D19044: [InlineMessage] Do not draw shadows around the message

ndavis added a comment. TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. Here's how it looks with Breeze Dark.F6622189: Screenshot_20190218_172518.png REPOSITORY R169 Kirigami REVISION DETAIL

D19044: [InlineMessage] Do not draw shadows around the message

ngraham added a comment. In D19044#414479 , @mart wrote: > -1 > this has to be done at most for the desktop style and the desktop style only Can you explain a bit more? I don't understand the technical reason for why you think we

D19044: [InlineMessage] Do not draw shadows around the message

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. -1 this has to be done at most for the desktop style and the desktop style only REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg,

D19044: [InlineMessage] Do not draw shadows around the message

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. +1 for all the reasons you gave! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham

D19044: [InlineMessage] Do not draw shadows around the message

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch removes InlineMessage's DropShadow for the following reasons: 1. consistency - there are no shadows in QWidgets'