D19079: Make look of Font Management KCM UI more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8596ae908533: Make look of Font Management KCM UI more consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51877=51893

D19079: Make look of Font Management KCM UI more consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks! REPOSITORY R119 Plasma Desktop BRANCH make-look-of-font-management-kcm-ui-more-consistent (branched from master) REVISION DETAIL

D19079: Make look of Font Management KCM UI more consistent

GB_2 updated this revision to Diff 51877. GB_2 added a comment. Use /Cancel style message box buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51866=51877 BRANCH make-look-of-font-management-kcm-ui-more-consistent (branched from

D19079: Make look of Font Management KCM UI more consistent

GB_2 added a comment. In D19079#413663 , @ngraham wrote: > While we're at it, can we turn those Yes/No messageboxes into /Cancel style instead? Sure REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19079

D19079: Make look of Font Management KCM UI more consistent

ngraham added a comment. While we're at it, can we turn those Yes/No messageboxes into /Cancel style instead? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19079 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D19079: Make look of Font Management KCM UI more consistent

GB_2 updated this revision to Diff 51866. GB_2 added a comment. Remove unneeded ellipses REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51855=51866 BRANCH arcpatch-D19079 REVISION DETAIL https://phabricator.kde.org/D19079 AFFECTED

D19079: Make look of Font Management KCM UI more consistent

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > Heh I think that may be a typo and the word was supposed to be "excluding". I > specifically remember having a conversation about this and we concluded that > confirmation prompts didn't count because then you

D19079: Make look of Font Management KCM UI more consistent

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in KCmFontInst.cpp:236 > The HIG says "Indicate a command that needs additional information (including > confirmation) by adding an ellipsis at the end of the button label." Heh I think that may be a typo and the word was supposed to

D19079: Make look of Font Management KCM UI more consistent

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > This one doesn't need an ellipsis. If the window/dialog that pops up when you > click on it is nothing more than a confirmation box, we don't use ellipsis. > > However the confirmation dialog that results from

D19079: Make look of Font Management KCM UI more consistent

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KCmFontInst.cpp:236 > +itsDeleteGroupControl=new CPushButton(KGuiItem(QString(), "list-remove", > +