This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8b413729da44: Improve the look of the Emoticons KCM UI
(authored by GB_2).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19093?vs=51978=51979
REVISION
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
+1 shipit!
REPOSITORY
R119 Plasma Desktop
BRANCH
improve-look-of-emoticons-kcm-ui (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19093
To: GB_2, #plasma,
GB_2 updated this revision to Diff 51978.
GB_2 added a comment.
Address comments
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19093?vs=51905=51978
BRANCH
improve-look-of-emoticons-kcm-ui (branched from master)
REVISION DETAIL
ngraham added inline comments.
INLINE COMMENTS
> emoticonslist.cpp:364
> {
> -const QString name = KInputDialog::getText(i18n("New Emoticon Theme"),
> i18n("Enter the name of the new emoticon theme:"));
> +const QString name = KInputDialog::getText(i18n("New Emoticon Theme"),
>
ngraham added a comment.
Awesome! Works great and looks so much better now. This new layout eliminates
that horizontal scrollbar too.
Just a few little nitpicks.
INLINE COMMENTS
> emoticonslist.ui:48
>
> - This will remove the selected theme from your disk.
> -
> -
GB_2 updated this revision to Diff 51905.
GB_2 added a comment.
Fix resizing
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19093?vs=51903=51905
BRANCH
improve-look-of-emoticons-kcm-ui (branched from master)
REVISION DETAIL
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.
REVISION SUMMARY
Apply the KDE HIG, make buttons consistent and make the KCM look better.
F6619998: Improved
