D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. In D19096#434638 , @abetts wrote: > Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in

D19096: Improvements for long label items in Application Dashboard

abetts added a comment. Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in comparison to the icon labels. Maybe those also need some touch up? REPOSITORY R119

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 54349. trmdi added a comment. This revision is now accepted and ready to land. Update code style, only fix the tooltip bug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52321=54349 BRANCH fix-tooltip

D19096: Improvements for long label items in Application Dashboard

hein added a comment. In D19096#427339 , @trmdi wrote: > In D19096#427329 , @hein wrote: > > > ... I'll need to set some time aside to analyze what you're trying to achieve there and propose an

D19096: Improvements for long label items in Application Dashboard

trmdi abandoned this revision. trmdi added a comment. In D19096#427329 , @hein wrote: > I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set

D19096: Improvements for long label items in Application Dashboard

hein added a comment. I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember

D19096: Improvements for long label items in Application Dashboard

hein added a comment. I'm sorry, but I can't accept this patch as-is - the hoverArea-related changes are just wrong, it's not OK to couple a delegate to the view by making it set tons of property on an item i its parent. I'll need to set some time aside to analyze what you're trying to

D19096: Improvements for long label items in Application Dashboard

trmdi added inline comments. INLINE COMMENTS > hein wrote in ItemGridDelegate.qml:117 > What do the hover changes do in this patch? :) It helps to display the tooltip. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma,

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52321. trmdi edited the test plan for this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52167=52321 REVISION DETAIL

D19096: Improvements for long label items in Application Dashboard

hein added inline comments. INLINE COMMENTS > ItemGridDelegate.qml:117 > + > +onContainsMouseChanged: { > +if (!containsMouse) { What do the hover changes do in this patch? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi,

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. On some small screens e.g <= 1024x768, `units.iconSizes.large` is a bit too big, it may look better with `units.iconSizes.medium` > property int iconSize: smallScreen ? units.iconSizes.large : units.iconSizes.huge Should I change it in this patch or create

D19096: Improvements for long label items in Application Dashboard

ngraham added a comment. Works great on my 1920x1080 screen BTW. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. In D19096#416391 , @hein wrote: > What's all the unrelated code changes about mouse handling trying to achieve? > > Have you tested this with a few common screen resolutions / aspect ratios? The original grid was

D19096: Improvements for long label items in Application Dashboard

hein added a comment. What's all the unrelated code changes about mouse handling trying to achieve? Have you tested this with a few common screen resolutions / aspect ratios? The original grid was designed to try and avoid getting into awkward row configurations on common ones.

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52167. trmdi added a comment. This revision is now accepted and ready to land. Do not drag the item after right clicking on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52130=52167 REVISION DETAIL

D19096: Improvements for long label items in Application Dashboard

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

ndavis added a comment. +1 from me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52130. trmdi added a comment. Fix tooltip's height. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52097=52130 REVISION DETAIL https://phabricator.kde.org/D19096 AFFECTED FILES