D19173: [InlineMessage] Tint icon and text color

2019-02-19 Thread Andres Betts
abetts added a comment. Love the color change. More harmonious. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19173 To: filipf, #kirigami, #vdg, ngraham Cc: abetts, mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D19173: [InlineMessage] Tint icon and text color

2019-02-19 Thread Filip Fila
filipf added a comment. You're right, let's not pursue this further at this point. Bit of more than I could chew anyway! But if anyone would be interested in doing something like this in the future, feel free to commandeer the revision. REPOSITORY R169 Kirigami REVISION DETAIL https://p

D19173: [InlineMessage] Tint icon and text color

2019-02-19 Thread Nathaniel Graham
ngraham added a subscriber: mart. ngraham added a comment. Also as @mart pointed out in D19044 , it might make sense to do all the styling in the qqc2 desktop style theme for this control, rather than here in Kirigami itself. Finally, I'm requiring tha

D19173: [InlineMessage] Tint icon and text color

2019-02-19 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm not in favor of this at all in its current form. Any tinting of the text with the background color under it reduces legibility. I'm as in favor of aesthetically appealing us

D19173: [InlineMessage] Tint icon and text color

2019-02-19 Thread Filip Fila
filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch tints both the icon and text colors of inline messages in order to achieve more appealing visuals. REPOSITORY R169 K