This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cd3e9a291a66: Rewrite kworkspace logout, shutdown and
suspend API (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19389?vs=60969&id=61013#toc
REPOSITORY
R120 Pla
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> loginddbustypes.h:105
> +{
> +public:
> +uint userId;
It's a `struct` already
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phab
davidedmundson updated this revision to Diff 60969.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Keep canSwitchUser behaviour from KDisplayManager
This patch fixes up libkworkspace all the powerdevil code,
all the shutdown code and all the ksmserver ca
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in sessionmanagement.cpp:95
> I don't see where it did
KDisplayManager::isSwitchable()
checks `CanMultiSession` on the session manager.
and there's also `numReserve()` which seems to be hardcoded to `1` for more
modern syste
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in sessionmanagement.cpp:95
> The old one also checked KDM or whatever for "free ttys", is that still a
> thing?
I don't see where it did
> broulik wrote in sessionmanagement.h:93
> Didn't we have a "don't ask" thing that al
davidedmundson updated this revision to Diff 60269.
davidedmundson marked 6 inline comments as done.
davidedmundson added a comment.
Review comments.
Also now doesn't break old API so we don't have to merge all at once.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https
broulik added inline comments.
INLINE COMMENTS
> loginddbustypes.h:103
> +
> +class NamedUserPath
> +{
You're using `struct` and `class` with all public inconsistently
> loginddbustypes.h:135
> +QString mode;
> +int userId;
> +uint processId;
`userId` is unsigned
> sessionmanageme
davidedmundson updated this revision to Diff 59811.
davidedmundson added a comment.
Update
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19389?vs=55363&id=59811
REVISION DETAIL
https://phabricator.kde.org/D19389
AFFECTED FILES
libkworkspace/
