D19510: [Logout screen] Fix label opacity failing

2019-03-06 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R120:076671638f1d: [Logout screen] Fix label opacity failing (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19510?vs=53317=53320

D19510: [Logout screen] Fix label opacity failing

2019-03-06 Thread Filip Fila
filipf updated this revision to Diff 53317. filipf added a comment. Add space between = and 1 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19510?vs=53316=53317 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 AFFECTED

D19510: [Logout screen] Fix label opacity failing

2019-03-06 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > LogoutButton.qml:34 > opacity: activeFocus || containsMouse ? 1 : 0.5 > +labelRendering: opacity !=1 ? Text.QtRendering : Text.NativeRendering // > Remove once we've solved Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 > (KDE bug:

D19510: [Logout screen] Fix label opacity failing

2019-03-06 Thread Filip Fila
filipf added a comment. @ngraham to further minimize the use of QtRendering I've added code so that it's used only when opacity is not 1. Is that okay? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 To: filipf, #plasma, ngraham,

D19510: [Logout screen] Fix label opacity failing

2019-03-06 Thread Filip Fila
filipf updated this revision to Diff 53316. filipf added a comment. Use QtRendering only when opacity is not 1 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19510?vs=53122=53316 BRANCH master REVISION DETAIL

D19510: [Logout screen] Fix label opacity failing

2019-03-04 Thread Krešimir Čohar
rooty added a comment. This is a neat workaround as discussed in D19479 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 To: filipf, #plasma, ngraham, rooty Cc: plasma-devel, jraleigh, GB_2,

D19510: [Logout screen] Fix label opacity failing

2019-03-04 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Due to Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 (KDE bug: https://bugs.kde.org/show_bug.cgi?id=401644) we have label