This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0f5c7ede9da2: [Desktop Sessions KCM] Add Restart to
BIOS/UEFI checkbox (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19560?vs=53661=53772#toc
REPOSITORY
R119 Plasma
ngraham accepted this revision.
ngraham added a comment.
The KMessageWidget within the group box is only weird because there's a group
box IMO. This KCM is a good candidate for being re-laid-out with a FormLayout
so it looks and feels like everything else these days. I can do that after this
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
LGTM.
I'll put it on the record that I still think the "yo you wanna restart now"
message should be at the top of the KCM and not inside the groupbox.
REPOSITORY
R119 Plasma Desktop
broulik updated this revision to Diff 53661.
broulik added a comment.
- Enable word wrap for message widget
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19560?vs=53659=53661
REVISION DETAIL
https://phabricator.kde.org/D19560
AFFECTED FILES
broulik updated this revision to Diff 53659.
broulik added a comment.
- Fix xml
- Better init dbus iface
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19560?vs=53652=53659
REVISION DETAIL
https://phabricator.kde.org/D19560
AFFECTED FILES
sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.
XML broken.
The KMessageWidget being inside the groupbox looks a bit weird to me. Don't
we usually put the messages at the top of the KCM?
INLINE COMMENTS
>
broulik updated this revision to Diff 53652.
broulik added a comment.
- Use introspected DBus stuff; used the nicer synchronous APIs, should be
fine since this isn't a background service that we must not block
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
sitter added a comment.
I feel like this would be nicer a dbus interface class thingy.
INLINE COMMENTS
> kcmsmserver.cpp:118
> +
> +if (enable) {
> +
> dialog->firmwareSetupMessageWidget->setMessageType(KMessageWidget::Information);
Perhaps reduce the nesting by
broulik updated this revision to Diff 53290.
broulik added a comment.
- Add efi, uefi, bios as keywords so the KCM can be found this way through
KRunner
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19560?vs=53279=53290
REVISION DETAIL
ngraham accepted this revision as: VDG.
ngraham added a comment.
Never mind, it's already gone. UI looks good to me!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19560
To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
ngraham added a comment.
Not sure we need the restart icon in the checkbox label.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19560
To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed,
broulik updated this revision to Diff 53279.
broulik edited the test plan for this revision.
broulik added a comment.
- Simplify, totally didn't realize the "impl" was just a UI subclass, just
access its controls directly from the kcm class
- Add "Restart Now" button to message widget
-
broulik updated this revision to Diff 53267.
broulik retitled this revision from "[Desktop Sessions KCM] Add Reboot to
BIOS/UEFI checkbox" to "[Desktop Sessions KCM] Add Restart to BIOS/UEFI
checkbox".
broulik added a comment.
- Change wording to "restarted" instead of rebooted and talk
13 matches
Mail list logo
