D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. In D19631#467171 , @filipf wrote: > We could also increase the width of each of the button's container, basically what this shows I guess is the Shut Down button barely fits in one row. I'll look into it. +1. I d

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-19 Thread Filip Fila
filipf added a comment. In D19631#467170 , @rikmills wrote: > > ! In D19631#467167 , @filipf wrote: > > > > Why does it look different than Neon? > > Seems neon have a settings tweak to force mo

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-19 Thread Rik Mills
rikmills added a comment. > ! In D19631#467167 , @filipf wrote: > > Why does it look different than Neon? Seems neon have a settings tweak to force more font Noto (especially for sddm). Cherry picking that... REPOSITORY R120 Plasma

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-19 Thread Filip Fila
filipf added a comment. In D19631#467156 , @rikmills wrote: > Not looking good. > > F6835091: c0924558f6.png Why does it look different than Neon? F6835124: image.png

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-19 Thread Rik Mills
rikmills added a comment. Not looking good. F6835091: c0924558f6.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: rikmills, davidedmundson, plasma-devel, jrale

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d3aa8b07c168: [sddm-theme/lock screen] Overhaul font sizes (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54020&id=54024 REV

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. I love it. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zr

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty updated this revision to Diff 54020. rooty added a comment. Remove extra character REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54019&id=54020 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D19631 AFFECTE

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty updated this revision to Diff 54019. rooty added a comment. Make it work for the lock screen too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54018&id=54019 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty updated this revision to Diff 54018. rooty added a comment. Implement changes in keyboard layout button REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54017&id=54018 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kd

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty updated this revision to Diff 54017. rooty added a comment. Add battery font size configuration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54012&id=54017 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D1

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty updated this revision to Diff 54012. rooty marked an inline comment as done. rooty added a comment. Make property less restricted REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54005&id=54012 BRANCH arcpatch-D19631 REVISION DETAI

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty marked an inline comment as done. rooty added inline comments. INLINE COMMENTS > ngraham wrote in MediaControls.qml:126 > These changes will worsen the problem of the song/artist name getting cut off > when they're even marginally long. I would be in favor of fixing that (in > another pat

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Krešimir Čohar
rooty updated this revision to Diff 54005. rooty added a comment. Use track and artist style from D17073 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53632&id=54005 BRANCH arcpatch-D19631 REVISION

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-16 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, I think this is sane enough now. :) INLINE COMMENTS > MediaControls.qml:126 > Layout.fillWidth: true > -level: 5 > +level: 4 >

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-14 Thread Filip Fila
filipf accepted this revision as: filipf. filipf added a comment. If we're not going to be able to change SDDM's default font, this is the second best solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Krešimir Čohar
rooty updated this revision to Diff 53632. rooty added a comment. Use Math.max instead of OR (works with other distros now) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53577&id=53632 BRANCH arcpatch-D19631 REVISION DETAIL https://

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Filip Fila
filipf added a comment. Looks good now, but let's see if we could simply change SDDM to default to 10pt like the desktop instead of 9pt. @davidedmundson do you perhaps know where we could change this setting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Krešimir Čohar
rooty updated this revision to Diff 53577. rooty added a comment. Missed one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53576&id=53577 BRANCH revert-more (branched from master) REVISION DETAIL https://phabricator.kde.org/D19631

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-10 Thread Krešimir Čohar
rooty updated this revision to Diff 53576. rooty added a comment. Simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53561&id=53576 BRANCH revert-more (branched from master) REVISION DETAIL https://phabricator.kde.org/D19631 AF

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53561. rooty edited the summary of this revision. rooty added a comment. Make the logout screen work too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53557&id=53561 BRANCH revert-more (branched from

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. Can anyone please help - how do I tell Main.qml to set the integer "nameFontSize" to 12 pt? My knowledge here is very limited and nothing I've tried has worked :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg,

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53518. rooty edited the summary of this revision. rooty added a comment. (WIP) Switch back to the default theme font + 1 (or 2) for the lock screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53498&id

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. > What hardcoding font sizes gives us are 2 places in Plasma losing their flexibility and not taking the user's preferences into consideration = SDDM-ing it. Then the solution is obvious - we should make the sddm theme (SDDM itself) more customizable (theme.conf?)

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Filip Fila
filipf added a comment. In D19631#427731 , @rooty wrote: > In D19631#427726 , @filipf wrote: > > > There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM isn

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. In D19631#427726 , @filipf wrote: > There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM isn't on par with it. If there's no other way, hardcoded font sizes should only be presen

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a subscriber: davidedmundson. rooty added a comment. @davidedmundson thoughts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Filip Fila
filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM isn't on par with it. If there's no other way, hardcoded font sizes should only be

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH revert-more (branched from master) REVISION DETAIL https://phabricator.kde.org/D19631 AFFECTED FILES loo