D19707: Make QQC2 desktop style a RUNTIME dependency

2019-03-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:737b114c2fa5: Make QQC2 desktop style a RUNTIME dependency (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19707?vs=53721&id=53734 REV

D19707: Make QQC2 desktop style a RUNTIME dependency

2019-03-12 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 for concept, functionality, and execution. Use whatever string seems most appropriate to you, I say. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/

D19707: Make QQC2 desktop style a RUNTIME dependency

2019-03-12 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > fvogt wrote in CMakeLists.txt:68 > IIRC not only KCMs, but also some other dialogs I just copied that over from the line above :) Plasma config dialogs also loosely qualify as KCMs REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D19707: Make QQC2 desktop style a RUNTIME dependency

2019-03-12 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > CMakeLists.txt:68 > +DESCRIPTION "QtQuickControls 2 style that uses QWidget's QStyle for > painting" > +PURPOSE "Required at runtime by many KCMs" > +TYPE RUNTIME IIRC not only KCMs, but also some other dialogs REPOSITORY R119 Plasma

D19707: Make QQC2 desktop style a RUNTIME dependency

2019-03-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, sitter, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Should avoid cases of "my settings look ugly" because it is not installed TEST PLAN