D19711: Use brush for painting line edits

mwoehlke added inline comments. INLINE COMMENTS > cfeck wrote in oxygenstyle.cpp:3273 > Why the reference? Force of habit... supposedly it forces copy elision (although new C++ is trying to make that happen regardless). Same pattern is used for `rect` and `palette` a couple lines above here.

D19711: Use brush for painting line edits

cfeck added inline comments. INLINE COMMENTS > oxygenstyle.cpp:3273 > > -const QColor background( palette.color( QPalette::Base ) ); > +const QBrush& background( palette.brush( QPalette::Base ) ); > Why the reference? REPOSITORY R113 Oxygen Theme REVISION DETAIL

D19711: Use brush for painting line edits

mwoehlke updated this revision to Diff 53743. mwoehlke added a comment. Also use brush in fallback path REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19711?vs=53742&id=53743 REVISION DETAIL https://phabricator.kde.org/D19711 AFFECTED FILES kstyl

D19711: Use brush for painting line edits

mwoehlke added a comment. Note: this is "inspired" by qtColorButton , which uses a textured brush for colors with non-opaque alpha. This renders correctly with built-in styles, but not with current Oxygen. (I have a

D19711: Use brush for painting line edits

mwoehlke created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mwoehlke requested review of this revision. REVISION SUMMARY Modify Style::drawFrameLineEditPrimitive to use the brush rather than the color to fill the background of line edits. This is mor