D19797: [fifteen-clock] Modernize settings window

2019-03-16 Thread Nathaniel Graham
ngraham added a comment. +1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me. This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe? REPOSITO

D19797: [fifteen-clock] Modernize settings window

2019-03-15 Thread Filip Fila
filipf updated this revision to Diff 53983. filipf added a comment. forgot anchors again REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19797?vs=53981&id=53983 BRANCH modernize-15clock-settings (branched from master) REVISION DETAIL https://phab

D19797: [fifteen-clock] Modernize settings window

2019-03-15 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Fifteen-clock's configuration window is ported to QQC2 and Kirigami.FormLayout. Setting are reorganized in a way that makes more se