D19829: kicker: add option to make root level icons visible

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f5ad1bfc33a4: kicker: add option to make root level icons visible (authored by i.Dark_Templar, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. In D19829#472621 , @ngraham wrote: > @i.Dark_Templar can you land this yourself? I don't think I have access for that. Also I don't have Arc at the moment, and there's no indication in web interface that I

D19829: kicker: add option to make root level icons visible

ngraham added a comment. @i.Dark_Templar can you land this yourself? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D19829: kicker: add option to make root level icons visible

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I'm still a bit grumpy about this and dragging my feet! My gut still says it's both option clutter and UI noise :-) However: - There's a fair amount of people calling for this now.

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19829: kicker: add option to make root level icons visible

ngraham added 1 blocking reviewer(s): hein. ngraham added a comment. This revision now requires review to proceed. Ultimately it's up to @hein as the maintainer. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg,

D19829: kicker: add option to make root level icons visible

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Works great. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel,

D19829: kicker: add option to make root level icons visible

i.Dark_Templar updated this revision to Diff 57202. i.Dark_Templar added a comment. Rebased to master, but it needs testing. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19829?vs=54094=57202 REVISION DETAIL https://phabricator.kde.org/D19829

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. I would accept it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. In D19829#456234 , @GB_2 wrote: > Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/`arc` in the future:

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/`arc` in the future: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. In D19829#432852 , @i.Dark_Templar wrote: > Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it may be enabled if this change is applied. And in my opinion it looks more

D19829: kicker: add option to make root level icons visible

hein added a comment. Kicker intentionally doesn't have icons on the root level to not conflict with the favorites column and reduce visual noise. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: ngraham,

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. Attaching screenshot with current look of menu (or with disabled option) and new look with enabled option and also a configuration widget. F6698363: kde-menu-changes.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19829: kicker: add option to make root level icons visible

ngraham added reviewers: Plasma, VDG. ngraham added a comment. Screenshots are always appreciated for changes to the UI. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: ngraham, plasma-devel, jraleigh,

D19829: kicker: add option to make root level icons visible

i.Dark_Templar created this revision. i.Dark_Templar added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. i.Dark_Templar requested review of this revision. REVISION SUMMARY In file applets/kicker/package/contents/config/main.xml an option