D19855: Fix bugzilla login page widgets tab order

2019-06-24 Thread Harald Sitter
sitter commandeered this revision. sitter edited reviewers, added: marcelomariano; removed: sitter. sitter added a comment. Ah yes, so it is. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: sitter, cfeck, #plasma, marcelomariano Cc: plasma-devel,

D19855: Fix bugzilla login page widgets tab order

2019-06-23 Thread Christoph Feck
cfeck added a comment. Is this fixed by https://phabricator.kde.org/D21894 ? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marcelomariano, sitter, cfeck, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D19855: Fix bugzilla login page widgets tab order

2019-03-19 Thread Marcelo Mariano
marcelomariano added reviewers: sitter, cfeck, Plasma. marcelomariano added a comment. That is true. I will consider taking a look at KPasswordLineEdit implementation. Thanks a lot! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marcelomariano,

D19855: Fix bugzilla login page widgets tab order

2019-03-19 Thread Marcelo Mariano
marcelomariano removed reviewers: patrickelectric, sitter, cfeck, Plasma. marcelomariano added a comment. That is true. I will consider taking a look at KPasswordLineEdit implementation. Thanks a lot! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To:

D19855: Fix bugzilla login page widgets tab order

2019-03-18 Thread Christoph Feck
cfeck added a comment. QLineEdit has Qt::StrongFocus policy and it is the focus proxy of KPasswordLineEdit. My impression was that KPasswordLineEdit then automatically also had Qt::StrongFocus. Appearantly, the policy is propagated in the other direction, so a correct fix would be to

D19855: Fix bugzilla login page widgets tab order

2019-03-18 Thread Harald Sitter
sitter added a comment. While that fixes the drkonqi bug just fine I am not sure that is the best fix for the problem. As I understand it KPasswordLineEdit doesn't set itself to StrongFocus, seeing as it is a replacement for QLineEdit that seems inconsistent and should be rectified though.

D19855: Fix bugzilla login page widgets tab order

2019-03-18 Thread Marcelo Mariano
marcelomariano created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. marcelomariano requested review of this revision. REVISION SUMMARY BUG: 398275 REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 AFFECTED FILES