This revision was automatically updated to reflect the committed changes.
Closed by commit R856:3989f42ac5f0: [DownloadJob] Report total size only if
known (authored by broulik).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
broulik updated this revision to Diff 56318.
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19857?vs=54234=56318
REVISION DETAIL
https://phabricator.kde.org/D19857
AFFECTED FILES
host/downloadjob.cpp
To: broulik, #plasma, fvogt
Cc:
fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.
Additionally, the `bytesReceived > totalAmount` case is currently not handled
at all, but I'm not sure whether that's something for `KJob` or here.
INLINE COMMENTS
>
broulik added a comment.
It should just hide the total if unknown but that's an issue in the
notification view
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D19857
To: broulik, #plasma
Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
bshah added a comment.
Other download managers show the downloaded amount as total amount, so it is
e.g 25 MiB out of 25 MiB.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D19857
To: broulik, #plasma
Cc: bshah, plasma-devel, jraleigh, GB_2,
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
In case the download size isn't known, the browser reports `-1`
TEST PLAN
It now shows "xyz
