D1986: WIP: Save PanelView settings in terms of grid units

2017-11-15 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. Can't remember what the state of this is, and the original code probably changed. Closing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1986 To: davidedmundson, #plasma Cc: mart,

[Differential] [Commented On] D1986: WIP: Save PanelView settings in terms of grid units

2016-07-04 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?) We /could/ but using a hybrid of two scaling systems seems like it'll get complex INLINE COMMENTS >

[Differential] [Commented On] D1986: WIP: Save PanelView settings in terms of grid units

2016-06-28 Thread mart (Marco Martin)
mart added a comment. anyways, i like the idea. uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Changed Subscribers] D1986: WIP: Save PanelView settings in terms of grid units

2016-06-28 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > panelview.cpp:1096 > > +void PanelView::writeScaledConfigEntry(const char *name, int pixelSize) > +{ why adding a new setter and getter that work in pixels? if something like that should be added, i wuld like just working with grid units.

[Differential] [Request, 43 lines] D1986: WIP: Save PanelView settings in terms of grid units

2016-06-23 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is useful for HighDPI otherwise a user needs to manually resize the panel initially