D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4516ab53726c: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

mart accepted this revision. mart added a comment. I think the patch is fine, the extra spacing is probably in the shell package plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml you can take a look there and see where things are maybe

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. In D19873#442385 , @hein wrote: > Looks solid to me. Is your concern re vertical spacing still valid? Thanks for having a look. Vertical spacing in wallpaper plugins is now OK, but unfortunately the spacing is

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

hein added a comment. Looks solid to me. Is your concern re vertical spacing still valid? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham, mart Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh,

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. I think it would be good if someone from #plasma could have a look if this is okay, I did do a lot of modifications. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19873

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 55283. filipf added a comment. . REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=55282=55283 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19873 AFFECTED FILES

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 55282. filipf added a comment. git... REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=55281=55282 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL https://phabricator.kde.org/D19873

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 55281. filipf added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54797=55281 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL https://phabricator.kde.org/D19873

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 54797. filipf added a comment. Don't break the slideshow wallpaper by putting everything in a form layout REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54790=54797 BRANCH fix-hor-alignment

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 54790. filipf added a comment. lose the unecessary QtQuick.Controls 1 import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54554=54790 BRANCH fix-hor-alignment (branched from master) REVISION

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works great with D19932 . Definitely seems like the correct fix. The rest of the code changes look good too. REPOSITORY R120 Plasma Workspace

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 54554. filipf added a comment. make the "Folders" string translatable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54484=54554 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. I've done a lot of clean up because: (1) some code is not needed for the FormLayout; (2) things worked the same without some code; (3) ported the combobox to QQC2 because the main layout is also using QQC2 comboboxes and everything still fits with normal scaling.