D19994: Add microphone indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2d82429e5299: Add microphone indicator (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19994?vs=57158=57234 REVISION

D19994: Add microphone indicator

broulik updated this revision to Diff 57158. broulik added a comment. - Address comments - Ignore virtual streams REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19994?vs=54606=57158 REVISION DETAIL https://phabricator.kde.org/D19994

D19994: Add microphone indicator

broulik added inline comments. INLINE COMMENTS > drosca wrote in plugin.cpp:67 > Any reason why you used singleton? So that we don't end up with multiple Status Notifier Items. This makes the indicator shared between all applets REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D19994: Add microphone indicator

abetts added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19994 To: broulik, #plasma, #vdg, drosca Cc: abetts, filipf, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D19994: Add microphone indicator

filipf added a comment. Yeah you want to ignore virtual devices or I guess this audio effects for eaxmple app would trigger the indicator? F6725598: image.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D19994: Add microphone indicator

drosca added a comment. Looks good. Personally I would work directly with the SourceOutputMap (and maybe duplicate it as list here in MicrophoneIndicator) instead of working with the models. I'm not saying that it's wrong / you should change it though, just a note. INLINE COMMENTS >

D19994: Add microphone indicator

broulik added a comment. > What happens if 2 applications are using it? It shows "foo, bar are using the microphone" > Maybe it would make sense to include the application icon as an overlay? For the tooltip, maybe. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D19994: Add microphone indicator

apol added a comment. What happens if 2 applications are using it? Maybe it would make sense to include the application icon as an overlay? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19994 To: broulik, #plasma, #vdg Cc: apol, plasma-devel,

D19994: Add microphone indicator

apol added a comment. BTW, +1 really cool :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19994 To: broulik, #plasma, #vdg Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D19994: Add microphone indicator

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Shows a System Tray icon when the microphone is being used. It also indicates the default