D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

This revision was automatically updated to reflect the committed changes. Closed by commit R119:da0adfedcab0: Make location of Lock Widgets and Remove Panel buttons more obvious (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg, ngraham Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, all right, let's go with the separator. :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

filipf added a comment. In D20144#442451 , @GB_2 wrote: > In D20144#441802 , @ngraham wrote: > > > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added subscribers: rooty, filipf, abetts, ndavis. GB_2 added a comment. In D20144#441802 , @ngraham wrote: > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them?

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 updated this revision to Diff 55225. GB_2 added a comment. Add separator and spacer between the two buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20144?vs=55139=55225 BRANCH master REVISION DETAIL

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. Hmm, maybe well then just with a spacer between them then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added a comment. In D20144#441087 , @ngraham wrote: > Maybe just switch the buttons' positions and add a spacer between them, then? I can try putting a spacer or seperator between the 2 buttons, but if I switch the positions of

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. Maybe just switch the buttons' positions and add a spacer between them, then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added a comment. In D20144#441083 , @ngraham wrote: > +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right next to Lock Widgets, which is non-destructive. Seems like it would be easy to

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406079 Move these two buttons to the left/top of the panel edit mode toolbar.