This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8f4ac7abc600: [SpinBox] Improve mouse wheel behavior
(authored by broulik).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
broulik updated this revision to Diff 55216.
broulik added a comment.
- Only use y delta, which is what `QAbstractSpinBox` does
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20155?vs=55170=55216
REVISION DETAIL
abetts added a comment.
Can you add a before/after video maybe? Just to see the changes
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D20155
To: broulik, #plasma
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
davidedmundson added inline comments.
INLINE COMMENTS
> SpinBox.qml:74
> onWheel: {
> -if (wheel.pixelDelta.y < 0 || wheel.angleDelta.y < 0) {
> -controlRoot.decrease();
> -} else {
> +var delta = wheel.angleDelta.y
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Emit `valueChanged` signal since this is an explicit user interaction.
Also, enforce "steps"
