D20205: initialize the kcolorscheme at the first app start

2019-04-03 Thread Marco Martin
mart added a comment. In D20205#442466 , @davidedmundson wrote: > The analysis makes sense, I don't understand why this is the correct fix. > > Colours aren't the only thing lookandfeel syncs to kdeglobals when set. > Is it correct that

D20205: initialize the kcolorscheme at the first app start

2019-04-02 Thread Eike Hein
hein added a comment. Or the QPA could look at the LnF in the first place instead of kdeglobals? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D20205 To: mart, #plasma Cc: hein, davidedmundson, plasma-devel, jraleigh, GB_2,

D20205: initialize the kcolorscheme at the first app start

2019-04-02 Thread David Edmundson
davidedmundson added a comment. The analysis makes sense, I don't understand why this is the correct fix. Colours aren't the only thing lookandfeel syncs to kdeglobals when set. Is it correct that all of them have a fallback to loading a second config? If they do, why does the lnf kcm

D20205: initialize the kcolorscheme at the first app start

2019-04-02 Thread Marco Martin
mart updated this revision to Diff 55286. mart added a comment. - revert mistake REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20205?vs=55285=55286 BRANCH phab/initializeColors REVISION DETAIL

D20205: initialize the kcolorscheme at the first app start

2019-04-02 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when an app starts when there isn't a kdeglobals yet, it reads from the color theme defined in the look