D20403: AppChooserDialog: make it more usable

2019-04-10 Thread Jan Grulich
jgrulich added a comment. Uppps, I accidentaly pushed the change instead running "arc diff". I made it to select app with just a single click as you wanted to, without buttons below. I'm not sure this will be easy to replace with KOpenWithDialog() as we receive from the portal just list

D20403: AppChooserDialog: make it more usable

2019-04-10 Thread Jan Grulich
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R838:5ddeff154725: AppChooserDialog: make it more usable (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Por

D20403: AppChooserDialog: make it more usable

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. +1 for unifying, and I'll admit that I kind of like this one better than the other one which is really complicated and fiddly. With an added search/filter field, this one would be just right. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DET

D20403: AppChooserDialog: make it more usable

2019-04-09 Thread Aleix Pol Gonzalez
apol added a comment. What Nate says makes sense to me. Single click should be fine, there's no real value in just selecting it. Don't we already have another dialog for choosing applications? It could make sense to use the same everywhere and improve it once. i.e. KOpenWithDialog from

D20403: AppChooserDialog: make it more usable

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. In D20403#446653 , @jgrulich wrote: > In D20403#446650 , @ngraham wrote: > > > IMO this should be a single-click UI, with no Open button: since there's nothing useful you c

D20403: AppChooserDialog: make it more usable

2019-04-09 Thread Jan Grulich
jgrulich added a comment. In D20403#446650 , @ngraham wrote: > IMO this should be a single-click UI, with no Open button: since there's nothing useful you can do with a selected item besides opening it, it should always open with a single-click

D20403: AppChooserDialog: make it more usable

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. IMO this should be a single-click UI, with no Open button: since there's nothing useful you can do with a selected item besides opening it, it should always open with a single-click. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL ht

D20403: AppChooserDialog: make it more usable

2019-04-09 Thread Jan Grulich
jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Add 'open' button so users doesn't need to choose only with double-click and also allow to open app with enter REPOSITORY R8