This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a4e231e7b6c0: Display a shortcut to the kcm Energy
Information from the battery applet… (authored by meven).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
meven updated this revision to Diff 60208.
meven added a comment.
Fix text
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20533?vs=56903=60208
BRANCH
arcpatch-D20533_2
REVISION DETAIL
https://phabricator.kde.org/D20533
AFFECTED FILES
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> meven wrote in batterymonitor.qml:142
> Thanks for pointing it out.
Not fixed yet. The text needs to be "Show Energy Information..."
REPOSITORY
R120
meven updated this revision to Diff 56903.
meven added a comment.
Check the energy information is available before showing a link to it, don't
show a link to it from the battery applet
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
meven marked an inline comment as done.
meven added inline comments.
INLINE COMMENTS
> ngraham wrote in batterymonitor.qml:142
> Generally we start menu items with action verbs. And in this case we don't
> need ellipsis because no further input from the user is required as a part of
> the
meven updated this revision to Diff 56602.
meven added a comment.
Start menu action with a verb
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20533?vs=56588=56602
BRANCH
arcpatch-D20533
REVISION DETAIL
https://phabricator.kde.org/D20533
ngraham added inline comments.
INLINE COMMENTS
> batterymonitor.qml:142
> +if (batterymonitor.kcmEnergyInformationAuthorized) {
> +plasmoid.setAction("energyinformationkcm", i18n("
> Information..."), "battery");
> +}
Generally we start menu items with action verbs.
meven updated this revision to Diff 56588.
meven added a comment.
Inverted checks
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20533?vs=56587=56588
BRANCH
arcpatch-D20533_1
REVISION DETAIL
https://phabricator.kde.org/D20533
AFFECTED FILES
