D20576: Add new notifications KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:be5819d0cab7: Merge branch 'kcm-redesign/notifications' (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=57758&id=57797 REVISI

D20576: Add new notifications KCM

broulik updated this revision to Diff 57758. broulik added a comment. - Don't leak `KNotification` - Ensure proper transient REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=57652&id=57758 REVISION DETAIL https://phabricator.kde.org/D2057

D20576: Add new notifications KCM

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't like this thing with source proxy. But I can kinda see what it's doing and it looks like it'll work. Lets go for it REPOSITORY R119 Plasma Desktop REVISION D

D20576: Add new notifications KCM

broulik updated this revision to Diff 57652. broulik added a comment. - Load source model only on sources page but do so immediately there when needed - Don't set width inside layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=57047&id

D20576: Add new notifications KCM

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in SourcesPage.qml:60 > Can you talk me through all this: > > We have a listview with a filtered model with a selected item > We change the filter > > As long as the proxies are working correctly and track a movement as a >

D20576: Add new notifications KCM

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ApplicationConfiguration.qml:103 > you shouldn't specify a width inside a layout. implicitWidth or Layout.preferredWidth REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #pl

D20576: Add new notifications KCM

davidedmundson added inline comments. INLINE COMMENTS > ApplicationConfiguration.qml:103 > +Item { > +width: Kirigami.Units.gridUnit > +} you shouldn't specify a width inside a layout. > SourcesPage.qml:35 > +Component.onCompleted: { > +// TOD

D20576: Add new notifications KCM

broulik updated this revision to Diff 57047. broulik added a comment. - Drop remove feature for seen apps. They shouldn't really pile up, as discussed with VDG - Some cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=56304&id=57047

D20576: Add new notifications KCM

mart added inline comments. INLINE COMMENTS > broulik wrote in sourcesmodel.cpp:243 > Not a stupid question, most likely a leftover delete? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: mart, ndavis, GB_2, mmustac, ngraham

D20576: Add new notifications KCM

GB_2 added a comment. You can now use `edit-remove`, which got added in D20700 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, jrale

D20576: Add new notifications KCM

GB_2 added a comment. Here you go: https://phabricator.kde.org/D20700 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D20576: Add new notifications KCM

GB_2 added a comment. In D20576#451805 , @ngraham wrote: > Yeah, I was thinking of the Breeze icon theme one, which IMO looks better: > > F6777816: Screenshot_20190417_074431.png > > I agree that the

D20576: Add new notifications KCM

ngraham added a subscriber: ndavis. ngraham added a comment. In D20576#451796 , @GB_2 wrote: > Hmm, it seems like the Plasma theme `list-remove` is different from the normal Breeze icon theme `list-remove`. I think we should have the icon from t

D20576: Add new notifications KCM

GB_2 added a comment. Hmm, it seems like the Plasma theme `list-remove` is different from the normal Breeze icon theme `list-remove`. I think we should have the icon from the Plasma theme in the Breeze icon theme too, but with a different name, so we don't overwrite the existing one. REPOSI

D20576: Add new notifications KCM

mmustac added a comment. What about edit-clear-symbolic or window-close (I think this would be the same as for the dismiss action in the widget?) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: mmustac, ngraham, zzag, plas

D20576: Add new notifications KCM

broulik added a comment. List-remove looks awful in this context F6777476: Screenshot_20190417_105550.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ngraham, zzag, plasma-devel

D20576: Add new notifications KCM

ngraham added a comment. In D20576#451149 , @broulik wrote: > In D20576#450778 , @ngraham wrote: > > > The trash icons in the app list make me think that it's going to uninstall those apps lol >

D20576: Add new notifications KCM

broulik added a comment. In D20576#450778 , @ngraham wrote: > The trash icons in the app list make me think that it's going to uninstall those apps lol Suggestions welcome. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D20576: Add new notifications KCM

ngraham added a comment. The trash icons in the app list make me think that it's going to uninstall those apps lol REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel

D20576: Add new notifications KCM

broulik added inline comments. INLINE COMMENTS > zzag wrote in sourcesmodel.cpp:243 > A bit stupid question: how it gets deleted? Not a stupid question, most likely a leftover REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc:

D20576: Add new notifications KCM

zzag added inline comments. INLINE COMMENTS > sourcesmodel.cpp:243 > + > +KConfig *config = new KConfig(file, KConfig::NoGlobals); > + > config->addConfigSources(QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, A bit stupid question: how it gets deleted? RE

D20576: Add new notifications KCM

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This completely rewrites the notifications KCM using `libnotificationmanager`. All notificat