D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-08-18 Thread Carson Black
cblack abandoned this revision. cblack added a comment. Change made here is being made in D23242 . Abandoning this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20746 To: cblack, #plasma, hein, #vdg Cc: broulik, ngraham,

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-24 Thread Kai Uwe Broulik
broulik added a comment. But what happens if you have an app pinned and minimize its window? Then the app will always show regardless of whether it's minimized or not. On the other hand, we have the same issue for windows from the same activity or desktop, so I don't see why this particular

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-23 Thread Carson Black
cblack added a comment. In D20746#455012 , @ngraham wrote: > -snip- > Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature? The regular

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-23 Thread Nathaniel Graham
ngraham added a comment. The Icons-only task manager show apps, not windows/tasks. Apps don't get minimized; windows/tasks do. So I'm guessing that this feature isn't exposed in the IOTM because it conceptually doesn't make any sense given the IOTM's UX ("Show apps, not windows/tasks").

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-23 Thread Noah Davis
ndavis added a comment. @hein You appear to have been the one who created the first version of this line, but I can't figure out why it was added. This is the commit where it was added: commit 3b84f96dc32b60e45127b8d30111ac232f9e Author: Eike Hein Date: Fri Sep 5 22:

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-23 Thread David Edmundson
davidedmundson added subscribers: hein, davidedmundson. davidedmundson added a comment. The original code is pretty clear, this isn't just a bugfix over what the author originally intended, so we need to understand that first. Git logs didn't tell me enough detail why it's there. It was a

D20746: Remove disable for showing only minimized tasks on Icons only task manager

2019-04-22 Thread Carson Black
cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch removes the visible: property that hides the option to show only tasks that are minimized to users of the icons only task