D20787: process: add support for cgroups

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabrica

D20787: process: add support for cgroups

topimiettinen added a comment. F6790730: screenshot2.png REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20787 To: topimiettinen, #plasma, hein Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, al

D20787: process: add support for cgroups

apol added inline comments. INLINE COMMENTS > process.h:215 > > +QString& cGroup() const; // REF, make non-ref later! > +void setCGroup(const QString &cGroup); ///< Linux Control Group (cgroup) Just don't return &? I don't understand the comment. REPOSITORY R111 KSysguard Library R

D20787: process: add support for cgroups

davidedmundson added a comment. Thanks INLINE COMMENTS > process.h:215 > > +QString& cGroup() const; // REF, make non-ref later! > +void setCGroup(const QString &cGroup); ///< Linux Control Group (cgroup) may as well make it non-ref now. I assume that ref pattern existed as an old

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 56908. topimiettinen added a comment. update per comments from @davidedmundson and @apol REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=56891&id=56908 BRANCH master REVISION DETAIL https:/

D20787: process: add support for cgroups

topimiettinen added a comment. It looks like the CGroup rows are visually not vertically aligned to center like other cells, but instead they are aligned to the top. However, I'd expect that the default item of switch in ProcessModel.cpp:1693 should implement this, like it does for e.g. Head

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57067. topimiettinen added a comment. Trim trailing newline for proper vertical alignment REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=56908&id=57067 BRANCH master REVISION DETAIL https:

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57068. topimiettinen added a comment. phabricate only one git commit, sorry REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57067&id=57068 BRANCH master REVISION DETAIL https://phabricator.

D20787: process: add support for cgroups

topimiettinen added a comment. F6795486: screenshot3.png Looks much better! REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20787 To: topimiettinen, #plasma, hein, davidedmundson Cc: davidedmundson, a

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57069. topimiettinen added a comment. fix copy-pasta REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57068&id=57069 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20787 AFFECTE

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57196. topimiettinen added a comment. hide cgroup column by default REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57069&id=57196 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D20787: process: add support for cgroups

This revision was automatically updated to reflect the committed changes. Closed by commit R111:3eb5e842ae64: process: add support for cgroups (authored by topimiettinen). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57196&id=58245 REVISI