D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eaa5f94c0584: [Lock, login logout screen] Add visual feedback to action buttons when pressed (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf updated this revision to Diff 57909. filipf added a comment. - change easing type from InOutQuad to InOutQuart to improve behavior when clicked fast - shorten the animation for the same reason REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf marked an inline comment as done. filipf added a comment. Here's what I'm trying to avoid: F6815617: ActionButtonPressedEffect When pressing fast and in the lock screen we can see the circle is still in the process of being scaled to 1.

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf marked 3 inline comments as done. filipf added a comment. I'm going to look into the different easing curves a bit more because I sometimes see the semi-scaled circle if clicking too fast. INLINE COMMENTS > broulik wrote in ActionButton.qml:76 > Can't you just `scale` the item

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf updated this revision to Diff 57735. filipf added a comment. - remove ID - height = width - use and animate scale instead of height & width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21062?vs=57699=57735 BRANCH

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

broulik added a comment. Looks lovely! INLINE COMMENTS > ActionButton.qml:69 > +Rectangle { > +id: highlightCircle > +anchors.centerIn: iconCircle This item isn't referenced, so it doesn't need to have an id > ActionButton.qml:71 > +anchors.centerIn: iconCircle

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH add-pressed-state-to-action-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D21062 To: filipf, #vdg, #plasma, ngraham, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen,

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

ngraham accepted this revision. ngraham added a comment. Lovely! These kinds of very subtle animations are super classy IMO. REPOSITORY R120 Plasma Workspace BRANCH add-pressed-state-to-action-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D21062 To: