This revision was automatically updated to reflect the committed changes.
Closed by commit R106:c5bc3a6c5d31: Null pointer dereference at ksysguard
(authored by gkaragiannidis, committed by davidedmundson).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
gkaragiannidis updated this revision to Diff 58214.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21147?vs=57914=58214
REVISION DETAIL
https://phabricator.kde.org/D21147
AFFECTED FILES
ksysguardd/conf.c
To: gkaragiannidis
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2,
davidedmundson added a comment.
> I don't know the procedure though; should I do anything?
You can update a diff
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D21147
To: gkaragiannidis
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
gkaragiannidis marked an inline comment as done.
gkaragiannidis added a comment.
Yes it would read better indeed.
I don't know the procedure though; should I do anything?
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D21147
To: gkaragiannidis
Cc: apol,
apol added a comment.
+1 overall.
INLINE COMMENTS
> conf.c:111
> +if((tmp = strchr( confLog->name, ':' )) != NULL)
> +{
> + *tmp = '\0';
it would probably read better as `if (tmp)`.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D21147
