ngraham added a comment.
@siddharthasahu would you like to continue working on this?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21192
To: siddharthasahu, ngraham, #plasma, #vdg
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,
filipf added a comment.
I only worked on the visuals of the theme so I'm not 100% sure either, but
there is extra dummy data that might be worth looking it, sddm.qml in
particular:
https://github.com/KDE/plasma-workspace/tree/master/sddm-theme/dummydata
REPOSITORY
R120 Plasma Workspace
siddharthasahu added a comment.
I took another look. As I already mentioned, there seems to be a difference
between how `onLoginFailed` signals work in both.
In the lock screen:
- the `onLoginFailed`
filipf added a comment.
I agree with David, when doing these sorts of changes it's imperative they're
instantly implemented in all relevant places. I checked SDDM (with our theme)
and the password field is disabled when in the timeout period so we need to fix
that.
Maybe this commit
siddharthasahu added a comment.
Friendly ping! Since the behaviour is already different, can we merge this
one and work on the SDDM part in a later PR?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21192
To: siddharthasahu, ngraham, #plasma, #vdg
Cc:
siddharthasahu added a comment.
Hi David!
Hmm, it seems the behavior is already different. I don't use sddm, but I
tried it just now and found that the input field is already *not* disabled,
plus, the notification that the login failed comes after the timeout. Looking
at the qml code,
ngraham added a comment.
Oh, duh, right. Yes, please change the login screen version too.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21192
To: siddharthasahu, ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
davidedmundson added a comment.
I don't want SDDM and the lockscreen to have subtly different behaviours.
If one is changing, the other should too.
See similar files in sddm-theme
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21192
To:
siddharthasahu added a comment.
This one was easy enough. I definitely liked the fact that I could edit the
qml files directly and test it live without going through a compilation step. I
especially enjoyed it after I managed to crash the lock screen with a typo but
was able to fix the
ngraham added a comment.
Yeah, isn't QML just so nice to work with!?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21192
To: siddharthasahu, ngraham, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed,
siddharthasahu added a comment.
Cool! Thank you for the pointers to the correct place. It was much easier
than I thought once I looked at the code.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21192
To: siddharthasahu, ngraham, #plasma, #vdg
Cc:
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Ah I see what you mean. It does look like the text field needs to become
defocused for a brief moment to work around that bug. And it re-focused itself
quickly while the button is still
siddharthasahu added a comment.
That's correct. 2 points however:
- I think the detection of a wrong password is very fast and at least on my
system I immediately get the highlighted focus. When you say muted, is it slow
to do this for you?
- We probably can't do the immediate focus
ngraham added a comment.
Thanks! In testing this out, I find that the impact is quite muted since the
text field de-focuses itself after you press the return key. So in practice, if
you realize that you typed the wrong password, you can't actually start typing
immediately because the text
siddharthasahu updated this revision to Diff 58025.
siddharthasahu added a comment.
Update diff to master.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21192?vs=58019=58025
REVISION DETAIL
https://phabricator.kde.org/D21192
AFFECTED FILES
ngraham added a comment.
I'm afraid your patch does not apply for me:
$ arc patch D21192
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D21192.
Checking patch lookandfeel/contents/lockscreen/MainBlock.qml...
error:
siddharthasahu created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
siddharthasahu requested review of this revision.
REVISION SUMMARY
This is a patch to fix: https://bugs.kde.org/show_bug.cgi?id=407473
TEST PLAN
I applied the diff on my system by
17 matches
Mail list logo
