D21234: Use a more conventional sidebar header apparance in desktop view

ngraham added a comment. That's exactly why manually setting the DPI isn't the correct way to enable high DPI mode. It only changes the fonts, so UI elements that aren't textual (like icon-only buttons, and icons in buttons) don't get scaled. You should use the scale factor slider in System

D21234: Use a more conventional sidebar header apparance in desktop view

zanny added a comment. Testing out the beta release that includes this change has the search bar overflow the menu list with high (160, in the example) DPI settings: F6838228: Screenshot_20190519_193434.png It gets worse the higher the DPI gets

D21234: Use a more conventional sidebar header apparance in desktop view

This revision was automatically updated to reflect the committed changes. Closed by commit R134:75e24b05e768: Use a more conventional sidebar header apparance in desktop view (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D21234: Use a more conventional sidebar header apparance in desktop view

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think this is much better. I like the inclusion of a home button as well. REPOSITORY R134 Discover Software Store BRANCH more-conventional-sidebar-header-appearance REVISION DETAIL

D21234: Use a more conventional sidebar header apparance in desktop view

filipf added a comment. +1 from a visual POV In D21234#465818 , @ndavis wrote: > I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is? See: https://phabricator.k

D21234: Use a more conventional sidebar header apparance in desktop view

ngraham added a comment. In D21234#465818 , @ndavis wrote: > I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is? Fixed in Discover. Any remaining divergence is now

D21234: Use a more conventional sidebar header apparance in desktop view

ngraham updated this revision to Diff 58150. ngraham added a comment. Fix margins REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21234?vs=58143&id=58150 BRANCH more-conventional-sidebar-header-appearance REVISION DETAIL https://phabric

D21234: Use a more conventional sidebar header apparance in desktop view

ndavis added a comment. I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21234 To: ngraham, #vdg, #discover_software_store, a

D21234: Use a more conventional sidebar header apparance in desktop view

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Discover uses the `Kirigami.GlobalDrawer` for its navigation sidebar. This c