davidedmundson abandoned this revision.
davidedmundson added a comment.
Discover has a pagniation model which if you only use the first page covers
this case.
Lets try and get that one in frameworks instead
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org
broulik added a comment.
Before moving to frameworks also needs d-pointer
INLINE COMMENTS
> limitedrowcountproxymodel_p.h:47
> + *
> + * The default value is 0
> + */
Should we use `-1` as the default instead and have 0 actually mean limit of
zero items = empty?
> limitedrowcou
davidedmundson updated this revision to Diff 58451.
davidedmundson added a comment.
update
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21326?vs=58442&id=58451
BRANCH
Plasma/5.16
REVISION DETAIL
https://phabricator.kde.org/D21326
AFFECTED
apol added inline comments.
INLINE COMMENTS
> limitedrowcountproxymodel.cpp:37
> {
> if (this->sourceModel()) {
> disconnect(this->sourceModel(), nullptr, this, nullptr);
it could make sense to check if it's different to the current one.
REPOSITORY
R120 Plasma Workspace
REVISI
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
For intended moving into KItemModels
REPOSITORY
R120 Plasma Workspace
BRA
