D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added a comment. Patch to fix: D21811 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added a comment. Ah, will fix. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-moham

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

davidedmundson added a comment. Following the code will find more bugs than testing. Once you resize down the layout minimumSize (and switchSize) changes and you won't switch. F6879656: Screenshot_20190609_110121.png old code would iconify

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in calculator.qml:39 > This will change with the font size, surely breaking it? I didn't see any regressions in testing... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #p

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

davidedmundson added inline comments. INLINE COMMENTS > calculator.qml:39 > Plasmoid.switchHeight: Layout.minimumHeight > Layout.minimumWidth: mainLayout.Layout.minimumWidth + 8 > Layout.minimumHeight: mainLayout.Layout.minimumHeight + 8 This will change with the font size, surely

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

This revision was automatically updated to reflect the committed changes. Closed by commit R114:987f5fe9bb12: [Calculator] Make buttons' text labels scale in size along with the widget (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. That 12 is a bit random, isn't it? But glad my approach just works™ REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #pl

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Calculator widget's button labels were not scaling in size as the widget got bigger, leadin